Re: [PATCH v2 1/7] mm/migrate: add comment about permanent failure path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 09, 2013 at 06:10:42PM +0900, Joonsoo Kim wrote:
>From: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
>
>Let's add a comment about where the failed page goes to, which makes
>code more readable.
>
>Acked-by: Christoph Lameter <cl@xxxxxxxxx>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
>Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
>

Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

>diff --git a/mm/migrate.c b/mm/migrate.c
>index 3747fcd..c6ac87a 100644
>--- a/mm/migrate.c
>+++ b/mm/migrate.c
>@@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
> 				nr_succeeded++;
> 				break;
> 			default:
>-				/* Permanent failure */
>+				/*
>+				 * Permanent failure (-EBUSY, -ENOSYS, etc.):
>+				 * unlike -EAGAIN case, the failed page is
>+				 * removed from migration page list and not
>+				 * retried in the next outer loop.
>+				 */
> 				nr_failed++;
> 				break;
> 			}
>-- 
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]