On 12/09/2013 07:40 PM, James Hogan wrote: > On 09/12/13 11:21, Chen Gang wrote: >> Oh, I tried gcc 4.6.3-2 rhel version, get the same result as yours (do >> not report warning), but for me, it is still a compiler's bug, it >> *should* report a warning for it, we can try below: > > Not necessarily. You can't expect the compiler to detect and warn about > more complex bugs the programmer writes, so you have to draw the line > somewhere. > Yeah, we can not only depend on compiler to help us finding bugs. > IMO missing some potential bugs is better than warning about code that > isn't buggy since that just makes people ignore the warnings or > carelessly try to silence them. > I can understand, every members have their own taste, so this patch is depended on related maintainers' taste (so kernel provided "EXTRA_CFLAGS=-W" to satisfy some of guys taste -- e.g. me). ;-) Thanks -- Chen Gang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>