On Fri, Dec 06, 2013 at 04:09:36PM -0500, Naoya Horiguchi wrote:
>On Fri, Dec 06, 2013 at 05:12:14PM +0800, Wanpeng Li wrote:
>> Use wrapper function task_node to get node which task is on.
>>
>> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>
>
>Maybe we have another line to apply the same fix:
>
>./kernel/sched/debug.c:142: SEQ_printf(m, " %d", cpu_to_node(task_cpu(p)));
>
Ok, I will fold it to next version. Thanks for your review. ;-)
Regards,
Wanpeng Li
>But anyway,
>
>Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
>
>Thanks,
>Naoya Horiguchi
>
>> ---
>> kernel/sched/fair.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 56bcc0c..e0b1063 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -1216,7 +1216,7 @@ static int task_numa_migrate(struct task_struct *p)
>> * elsewhere, so there is no point in (re)trying.
>> */
>> if (unlikely(!sd)) {
>> - p->numa_preferred_nid = cpu_to_node(task_cpu(p));
>> + p->numa_preferred_nid = task_node(p);
>> return -EINVAL;
>> }
>>
>> @@ -1283,7 +1283,7 @@ static void numa_migrate_preferred(struct task_struct *p)
>> p->numa_migrate_retry = jiffies + HZ;
>>
>> /* Success if task is already running on preferred CPU */
>> - if (cpu_to_node(task_cpu(p)) == p->numa_preferred_nid)
>> + if (task_node(p) == p->numa_preferred_nid)
>> return;
>>
>> /* Otherwise, try migrate to a CPU on the preferred node */
>> --
>> 1.7.7.6
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>