On Thu, Dec 05, 2013 at 04:52:52PM +0800, Jianguo Wu wrote:
> Two cleanups:
> 1. remove redundant codes for hugetlb pages.
> 2. end = pmd_addr_end(addr, end) restricts [addr, end) within PMD_SIZE,
> this may increase do_mincore() calls, remove it.
>
> Signed-off-by: Jianguo Wu <wujianguo@xxxxxxxxxx>
Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
Thanks!
Naoya
> ---
> mm/mincore.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/mm/mincore.c b/mm/mincore.c
> index da2be56..1016233 100644
> --- a/mm/mincore.c
> +++ b/mm/mincore.c
> @@ -225,13 +225,6 @@ static long do_mincore(unsigned long addr, unsigned long pages, unsigned char *v
>
> end = min(vma->vm_end, addr + (pages << PAGE_SHIFT));
>
> - if (is_vm_hugetlb_page(vma)) {
> - mincore_hugetlb_page_range(vma, addr, end, vec);
> - return (end - addr) >> PAGE_SHIFT;
> - }
> -
> - end = pmd_addr_end(addr, end);
> -
> if (is_vm_hugetlb_page(vma))
> mincore_hugetlb_page_range(vma, addr, end, vec);
> else
> --
> 1.7.1
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>