Hi Eric,
commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
Author: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
Date: Sat Oct 19 16:26:19 2013 -0700
tcp_memcontrol: Kill struct tcp_memcontrol
Replace the pointers in struct cg_proto with actual data fields and kill
struct tcp_memcontrol as it is not fully redundant.
This removes a confusing, unnecessary layer of abstraction.
Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
triggers a build warning because it removed the only reference to a
function but not the function itself:
linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
static void memcg_tcp_enter_memory_pressure(struct sock *sk)
I can not see from the changelog why this function is no longer used,
or who is supposed to now set cg_proto->memory_pressure which you
still initialize etc. Either way, the current state does not seem to
make much sense. The author would be the best person to double check
such changes, but he wasn't copied on your patch, so I copied him now.
Apologies if this has been brought up before, I could not find any
reference on LKML of either this patch or a report of this warning.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>