On Mon, Dec 02, 2013 at 03:09:42PM -0500, Naoya Horiguchi wrote:
> > diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> > index 0f65686..58624b4 100644
> > --- a/include/linux/rmap.h
> > +++ b/include/linux/rmap.h
> > @@ -239,6 +239,12 @@ struct rmap_walk_control {
> > int (*main)(struct page *, struct vm_area_struct *,
> > unsigned long, void *);
> > void *arg; /* argument to main function */
> > + int (*main_done)(struct page *page); /* check exit condition */
> > + int (*file_nonlinear)(struct page *, struct address_space *,
> > + struct vm_area_struct *vma);
> > + struct anon_vma *(*anon_lock)(struct page *);
> > + int (*vma_skip)(struct vm_area_struct *, void *);
>
> Can you add some comments about how these callbacks work and when it
> should be set to for future users? For example, anon_lock() are
> used to override the default behavior and it's not trivial.
Okay. I will add.
>
> > + void *skip_arg; /* argument to vma_skip function */
>
> I think that it's better to move this field into the structure pointed
> to by arg (which can be defined by each caller in its own way) and pass
> arg to *vma_skip().
Will do.
Thanks.
>
> Thanks,
> Naoya Horiguchi
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>