On Mon, Dec 02, 2013 at 07:41:15PM +0000, Christoph Lameter wrote:
> On Mon, 2 Dec 2013, Greg KH wrote:
>
> > No, the release callback is in the kobj_type, not the kobject itself.
>
> Ahh... Ok. Patch follows:
>
>
> Subject: slub: use sysfs'es release mechanism for kmem_cache
>
> Sysfs has a release mechanism. Use that to release the
> kmem_cache structure if CONFIG_SYSFS is enabled.
>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
That looks good, if you fix the indentation issue :)
>
> Index: linux/include/linux/slub_def.h
> ===================================================================
> --- linux.orig/include/linux/slub_def.h 2013-12-02 13:31:07.395905824 -0600
> +++ linux/include/linux/slub_def.h 2013-12-02 13:31:07.385906101 -0600
> @@ -98,4 +98,8 @@ struct kmem_cache {
> struct kmem_cache_node *node[MAX_NUMNODES];
> };
>
> +#ifdef CONFIG_SYSFS
> +#define SLAB_SUPPORTS_SYSFS
Why even define this? Why not just use CONFIG_SYSFS?
thanks,
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>