On Thu, Nov 28, 2013 at 10:12:55AM +0100, Michal Hocko wrote: > On Wed 27-11-13 18:33:53, Johannes Weiner wrote: > [...] > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 13b9d0f..5f9e467 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2675,7 +2675,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm, > > goto bypass; > > > > if (unlikely(task_in_memcg_oom(current))) > > - goto bypass; > > + goto nomem; > > > > /* > > * We always charge the cgroup the mm_struct belongs to. > > Yes, I think we really want this. Plan to send a patch? The first charge > failure due to OOM shouldn't be papered over by a later attempt if we > didn't get through mem_cgroup_oom_synchronize yet. Sure thing. Will send this to Andrew on Monday. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>