On Fri, 22 Nov 2013 14:30:47 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 22 Nov 2013 12:01:06 -0500 Luiz Capitulino <lcapitulino@xxxxxxxxxx> wrote:
>
> > Signed-off-by: Luiz capitulino <lcapitulino@xxxxxxxxxx>
> > ---
> > include/linux/mmzone.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> > index bd791e4..5e202d6 100644
> > --- a/include/linux/mmzone.h
> > +++ b/include/linux/mmzone.h
> > @@ -560,12 +560,12 @@ static inline bool zone_spans_pfn(const struct zone *zone, unsigned long pfn)
> > return zone->zone_start_pfn <= pfn && pfn < zone_end_pfn(zone);
> > }
> >
> > -static inline bool zone_is_initialized(struct zone *zone)
> > +static inline bool zone_is_initialized(const struct zone *zone)
> > {
> > return !!zone->wait_table;
> > }
> >
> > -static inline bool zone_is_empty(struct zone *zone)
> > +static inline bool zone_is_empty(const struct zone *zone)
> > {
> > return zone->spanned_pages == 0;
> > }
> > @@ -843,7 +843,7 @@ unsigned long __init node_memmap_size_bytes(int, unsigned long, unsigned long);
> > */
> > #define zone_idx(zone) ((zone) - (zone)->zone_pgdat->node_zones)
> >
> > -static inline int populated_zone(struct zone *zone)
> > +static inline int populated_zone(const struct zone *zone)
> > {
> > return (!!zone->present_pages);
> > }
>
> hm, why? I counted ten similarly constifyable functions in mm.h and
> stopped only 1/4 of the way through. What's so special about these three?
I spotted them while reading code. If you want to me convert the others,
I can do that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>