On Wed, Nov 20, 2013 at 10:12 PM, Weijie Yang <weijie.yang.kh@xxxxxxxxx> wrote: > On Thu, Nov 21, 2013 at 1:52 AM, Dan Streetman <ddstreet@xxxxxxxx> wrote: >> On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin <murzin.v@xxxxxxxxx> wrote: >>> Hi Dan! >>> >>> On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >>>> The "compressor" and "enabled" params are currently hidden, >>>> this changes them to read-only, so userspace can tell if >>>> zswap is enabled or not and see what compressor is in use. >>> >>> Could you elaborate more why this pice of information is necessary for >>> userspace? >> >> For anyone interested in zswap, it's handy to be able to tell if it's >> enabled or not ;-) Technically people can check to see if the zswap >> debug files are in /sys/kernel/debug/zswap, but I think the actual >> "enabled" param is more obvious. And the compressor param is really >> the only way anyone from userspace can see what compressor's being >> used; that's helpful to know for anyone that might want to be using a >> non-default compressor. >> >> And of course, eventually we'll want to make the params writable, so >> the compressor can be changed dynamically, and zswap can be enabled or >> disabled dynamically (or at least enabled after boot). > > Please do not make them writable. This patch doesn't make them writable. > There is no requirement to do that, and it will make zswap more complex. I can't speak for others, but I personally think being able to at least enable zswap after boot will be useful, as well as being able to change the compressor after boot. Obviously it will make zswap more complex, but that's the nature of improving software ;-) > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>