On Thu, 14 Nov 2013, Naoya Horiguchi wrote:
> Introduces a cosmetic substitution of the returned value of isolate_huge_page()
> to suppress a build warning when !CONFIG_HUGETLBFS. No behavioral change.
>
> Reported-by: Borislav Petkov <bp@xxxxxxxxx>
> Tested-by: Borislav Petkov <bp@xxxxxxxxx>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
> ---
> mm/migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 4cd63c2..4a26042 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1168,7 +1168,7 @@ static int do_move_page_to_node_array(struct mm_struct *mm,
> goto put_and_set;
>
> if (PageHuge(page)) {
> - isolate_huge_page(page, &pagelist);
> + err = isolate_huge_page(page, &pagelist);
> goto put_and_set;
> }
>
I think it would be better to just fix hugetlb.h to do
static inline bool isolate_huge_page(struct page *page, struct list_head *list)
{
return false;
}
for the !CONFIG_HUGETLB_PAGE variant.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>