On Tue, Nov 05, 2013 at 10:49:15AM +0800, ????????? wrote: > The patch is ok for unicore32. Thanks Al. > > While testing this patch, a bug is found in arch/unicore32/include/asm/pgtable.h: > > @@ -96,7 +96,7 @@ extern pgprot_t pgprot_kernel; > | PTE_EXEC) > #define PAGE_READONLY __pgprot(pgprot_val(pgprot_user | PTE_READ) > #define PAGE_READONLY_EXEC __pgprot(pgprot_val(pgprot_user | PTE_READ \ > - | PTE_EXEC) > + | PTE_EXEC)) > > In fact, all similar macros are wrong. I'll post an bug-fix patch for this obvious error. BTW, another missing thing is an analog of commit 9b61a4 (ARM: prevent VM_GROWSDOWN mmaps extending below FIRST_USER_ADDRESS); I'm not sure why does unicore32 have FIRST_USER_ADDRESS set to PAGE_SIZE (some no-MMU arm variants really need that, what with the vectors page living at address 0 on those), but since you have it set that way, you'd probably better not allow a mapping to grow down there... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>