On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@xxxxxxxx> wrote: > + > +void copy_high_order_page(struct page *newpage, > + struct page *oldpage, > + int order) > +{ > + int i; > + > + might_sleep(); > + for (i = 0; i < (1<<order); i++) { > + cond_resched(); > + copy_highpage(newpage + i, oldpage + i); > + } > +} Can we make no use of might_sleep here with cond_resched in loop? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>