On Thu, Oct 31, 2013 at 09:37:07AM +0100, Michal Hocko wrote: > On Wed 30-10-13 15:12:47, Andrew Morton wrote: > > Subject: + mm-memcg-use-proper-memcg-in-limit-bypass.patch added to -mm tree > > To: hannes@xxxxxxxxxxx,mhocko@xxxxxxx > > From: akpm@xxxxxxxxxxxxxxxxxxxx > > Date: Wed, 30 Oct 2013 15:12:47 -0700 > > > > > > The patch titled > > Subject: mm: memcg: use proper memcg in limit bypass > > has been added to the -mm tree. Its filename is > > mm-memcg-use-proper-memcg-in-limit-bypass.patch > > > > This patch should soon appear at > > http://ozlabs.org/~akpm/mmots/broken-out/mm-memcg-use-proper-memcg-in-limit-bypass.patch > > and later at > > http://ozlabs.org/~akpm/mmotm/broken-out/mm-memcg-use-proper-memcg-in-limit-bypass.patch > > > > Before you just go and hit "reply", please: > > a) Consider who else should be cc'ed > > b) Prefer to cc a suitable mailing list as well > > c) Ideally: find the original patch on the mailing list and do a > > reply-to-all to that, adding suitable additional cc's > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > The -mm tree is included into linux-next and is updated > > there every 3-4 working days > > > > ------------------------------------------------------ > > From: Johannes Weiner <hannes@xxxxxxxxxxx> > > Subject: mm: memcg: use proper memcg in limit bypass > > > > 84235de ("fs: buffer: move allocation failure loop into the allocator") > > allowed __GFP_NOFAIL allocations to bypass the limit if they fail to > > reclaim enough memory for the charge. Because the main test case was on a > > 3.2-based system, this patch missed the fact that on newer kernels the > > charge function needs to return root_mem_cgroup when bypassing the limit, > > and not NULL. This will corrupt whatever memory is at NULL + percpu > > pointer offset. Fix this quickly before problems are reported. > > > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Cc: Michal Hocko <mhocko@xxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Acked-by: Michal Hocko <mhocko@xxxxxxx> > > I guess this should be marked for stable as 84235de has been marked so. > It would be also nice to mention that bypass with root_mem_cgroup > happened at 3.3 times (it was done by 38c5d72f3ebe5 AFAICS). I recalled the stable tag for the other patch, will send the full series to stable once those patches have been in a release for some time. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>