> The concern is likely/unlikely usage is proper in this code peice. > If we don't use memory isolation, the code path is used for only > MIGRATE_RESERVE which is very rare allocation in normal workload. > > Even, in memory isolation environement, I'm not sure how many > CMA/HOTPLUG is used compared to normal alloc/free. > So, I think below is more proper? > > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (is_migrate_isolate(migratetype) || is_migrate_cma(migratetype)) > > I know it's an another topic but I'd like to disucss it in this time because > we will forget such trivial thing later, again. I completely agree with this. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>