On Thu, 2013-10-17 at 12:12 -0700, Andrew Morton wrote: > On Wed, 16 Oct 2013 20:51:18 -0700 (PDT) David Rientjes <rientjes@xxxxxxxxxx> wrote: > > > I haven't looked closely at scripts/get_maintainer.pl, but I recently > > wrote a patch touching mm/vmpressure.c and it doesn't list the file's > > author, Anton Vorontsov <anton.vorontsov@xxxxxxxxxx>. > > > > Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is > > missing and git blame attributs >90% of the lines to his authorship. > > > > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c > > Tejun Heo <tj@xxxxxxxxxx> (commit_signer:6/7=86%) > > Michal Hocko <mhocko@xxxxxxx> (commit_signer:5/7=71%) > > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:4/7=57%) > > Li Zefan <lizefan@xxxxxxxxxx> (commit_signer:3/7=43%) > > "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx> (commit_signer:1/7=14%) > > linux-mm@xxxxxxxxx (open list:MEMORY MANAGEMENT) > > linux-kernel@xxxxxxxxxxxxxxx (open list) > > get_maintainer should, by default, answer the question "who should I > email about this file". It clearly isn't doing this, and that's a > pretty big fail. I disagree. It's decidedly good at doing precisely that when a MAINTAINERS entry exists. When no one is a listed maintainer, the results can certainly be tweaked to be better. > I've learned not to trust it, so when I use it I always have to check > its homework with "git log | grep Author" :( > > Joe, pretty please? It's really a question of "how long ago is too long ago" as older commits way too often also show old/invalid email addresses. I also don't want to wait over 30 seconds or so to find out who is listed as a git signer/author by default. Adding the commit listed "Author:" as a signer doesn't seem too hard though. I'll play with that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>