Re: [PATCH 03/12] mm, thp, tmpfs: handle huge page cases in shmem_getpage_gfp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ning Qu wrote:
> you mean something like this? If so, then fixed.
> 
>                if (must_use_thp) {
>                         page = shmem_alloc_hugepage(gfp, info, index);
>                         if (page) {
>                                 count_vm_event(THP_WRITE_ALLOC);
>                         } else
>                                 count_vm_event(THP_WRITE_ALLOC_FAILED);
>                 } else {
>                         page = shmem_alloc_page(gfp, info, index);
>                 }
> 
>                 if (!page) {
>                         error = -ENOMEM;
>                         goto unacct;
>                 }
>                 nr = hpagecache_nr_pages(page);

Yeah.

count_vm_event() part still looks ugly, but I have similar in my code.
I'll think more how to rework in to make it better.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]