Re: [PATCH 10/26] lustre: Convert ll_get_user_pages() to use get_user_pages_fast()

["Dilger, Andreas" <andreas.dilger@xxxxxxxxx>]

On 2013/10/02 8:27 AM, "Jan Kara" <jack@xxxxxxx> wrote:
>CC: Greg Kroah-Hartman <greg@xxxxxxxxx>
>CC: Peng Tao <tao.peng@xxxxxxx>
>CC: Andreas Dilger <andreas.dilger@xxxxxxxxx>
>CC: hpdd-discuss@xxxxxxxxxxxx
>Signed-off-by: Jan Kara <jack@xxxxxxx>

Acked-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>

>---
> drivers/staging/lustre/lustre/llite/rw26.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/rw26.c
>b/drivers/staging/lustre/lustre/llite/rw26.c
>index 96c29ad2fc8c..7e3e0967993b 100644
>--- a/drivers/staging/lustre/lustre/llite/rw26.c
>+++ b/drivers/staging/lustre/lustre/llite/rw26.c
>@@ -202,11 +202,8 @@ static inline int ll_get_user_pages(int rw, unsigned
>long user_addr,
> 
> 	OBD_ALLOC_LARGE(*pages, *max_pages * sizeof(**pages));
> 	if (*pages) {
>-		down_read(&current->mm->mmap_sem);
>-		result = get_user_pages(current, current->mm, user_addr,
>-					*max_pages, (rw == READ), 0, *pages,
>-					NULL);
>-		up_read(&current->mm->mmap_sem);
>+		result = get_user_pages_fast(user_addr, *max_pages,
>+					     (rw == READ), *pages);
> 		if (unlikely(result <= 0))
> 			OBD_FREE_LARGE(*pages, *max_pages * sizeof(**pages));
> 	}


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href