On Sat, 28 Sep 2013 16:33:58 +0800 Bob Liu <lliubbo@xxxxxxxxx> wrote: > Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for > pages in pagevec released as cold page, so drop the cold argument from pagevec. Is it unreasonable? I'd say it's unreasonable to assume that all pages in all cases are likely to be cache-hot. Example: what if the pages are being truncated and were found to be on the inactive LRU, unreferenced? A useful exercise would be to go through all those pagevec_init() sites and convince ourselves that the decision at each place was the correct one. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>