Re: [PATCH] drm/i915: Fix up usage of SHRINK_STOP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 25, 2013 at 02:00:02PM +0200, Daniel Vetter wrote:
> In
> 
> commit 81e49f811404f428a9d9a63295a0c267e802fa12
> Author: Glauber Costa <glommer@xxxxxxxxxx>
> Date:   Wed Aug 28 10:18:13 2013 +1000
> 
>     i915: bail out earlier when shrinker cannot acquire mutex
> 
> SHRINK_STOP was added to tell the core shrinker code to bail out and
> go to the next shrinker since the i915 shrinker couldn't acquire
> required locks. But the SHRINK_STOP return code was added to the
> ->count_objects callback and not the ->scan_objects callback as it
> should have been, resulting in tons of dmesg noise like
> 
> shrink_slab: i915_gem_inactive_scan+0x0/0x9c negative objects to delete nr=-xxxxxxxxx
> 
> Fix discusssed with Dave Chinner.

Acked-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]