On 09/10/2013 12:29 AM, Seth Jennings wrote: > On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote: >> add SetPageReclaim before __swap_writepage so that page can be moved to the >> tail of the inactive list, which can avoid unnecessary page scanning as this >> page was reclaimed by swap subsystem before. >> >> Signed-off-by: Weijie Yang <weijie.yang@xxxxxxxxxxx> > > Acked-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > Below is a reply from Mel in original thread "[PATCHv11 3/4] zswap: add to mm/" ------------------ > + /* start writeback */ > + SetPageReclaim(page); > + __swap_writepage(page, &wbc, end_swap_bio_write); > + page_cache_release(page); > + zswap_written_back_pages++; > + SetPageReclaim? Why?. If the page is under writeback then why do you not mark it as that? Do not free pages that are currently under writeback obviously. It's likely that it was PageWriteback you wanted in zbud.c too. -------------------- -- Regards, -Bob -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>