On Tue, 17 Sep 2013, Chen Gang wrote: > > BUG_ON() is safe. but I still don't like it. As far as I heard, Google > > changes BUG_ON as nop. So, BUG_ON(mpol_to_str() < 0) breaks google. > > Please treat an assertion as assertion. Not any other something. > > Google does not disable BUG_ON(), sheesh. > Hmm... in kernel wide, BUG_ON() is 'common' 'standard' assertion, and > "mm/" is a common sub-system (not architecture specific), so when we > use BUG_ON(), we already 'express' our 'opinion' enough to readers. > That's ridiculous, we're not going to panic the kernel at runtime because a buffer is too small. Make it a compile-time error like I suggested so we catch this before we even build the kernel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>