On Wed, 2013-09-11 at 11:32 +0900, Yasuaki Ishimatsu wrote: > (2013/09/11 7:47), Toshi Kani wrote: > > cpu_up() has #ifdef CONFIG_MEMORY_HOTPLUG code blocks, which > > call mem_online_node() to put its node online if offlined and > > then call build_all_zonelists() to initialize the zone list. > > These steps are specific to memory hotplug, and should be > > managed in mm/memory_hotplug.c. lock_memory_hotplug() should > > also be held for the whole steps. > > > > For this reason, this patch replaces mem_online_node() with > > try_online_node(), which performs the whole steps with > > lock_memory_hotplug() held. try_online_node() is named after > > try_offline_node() as they have similar purpose. > > > > There is no functional change in this patch. > > > > Signed-off-by: Toshi Kani <toshi.kani@xxxxxx> > > --- > > v2: Added pr_err() in case of NULL pgdat in try_online_node(). > > --- > > Thank you for updating it. It looks good to me. > > Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx> Thanks Yasuaki! -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>