Re: [PATCH] mm: remove obsolete comments about page table lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Cced David Gibson who add this comment on powerpc part.
On Wed, Sep 04, 2013 at 12:50:23PM -0400, Naoya Horiguchi wrote:
>The callers of free_pgd_range() and hugetlb_free_pgd_range() don't hold
>page table locks. The comments seems to be obsolete, so let's remove them.
>
>Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
>---
> arch/powerpc/mm/hugetlbpage.c | 2 --
> mm/memory.c                   | 2 --
> 2 files changed, 4 deletions(-)
>
>diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>index 7e56cb7..31c20e2 100644
>--- a/arch/powerpc/mm/hugetlbpage.c
>+++ b/arch/powerpc/mm/hugetlbpage.c
>@@ -635,8 +635,6 @@ static void hugetlb_free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
>  * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
>  */
> void hugetlb_free_pgd_range(struct mmu_gather *tlb,
> 			    unsigned long addr, unsigned long end,
>diff --git a/mm/memory.c b/mm/memory.c
>index 6827a35..8c97ef0 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -478,8 +478,6 @@ static inline void free_pud_range(struct mmu_gather *tlb, pgd_t *pgd,
>
> /*
>  * This function frees user-level page tables of a process.
>- *
>- * Must be called with pagetable lock held.
>  */
> void free_pgd_range(struct mmu_gather *tlb,
> 			unsigned long addr, unsigned long end,
>-- 
>1.8.3.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]