On Fri, Aug 30, 2013 at 04:07:28PM +0200, Jerome Marchand wrote: >Since commit f40d1e4 (mm: compaction: acquire the zone->lock as late as >possible), isolate_freepages_block() takes the zone->lock itself. The >function description however still states that the zone->lock must be >held. >This patch removes this outdated statement. > Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> >Signed-off-by: Jerome Marchand <jmarchan@xxxxxxxxxx> >--- > mm/compaction.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/mm/compaction.c b/mm/compaction.c >index 05ccb4c..9f9026f 100644 >--- a/mm/compaction.c >+++ b/mm/compaction.c >@@ -235,10 +235,9 @@ static bool suitable_migration_target(struct page *page) > } > > /* >- * Isolate free pages onto a private freelist. Caller must hold zone->lock. >- * If @strict is true, will abort returning 0 on any invalid PFNs or non-free >- * pages inside of the pageblock (even though it may still end up isolating >- * some pages). >+ * Isolate free pages onto a private freelist. If @strict is true, will abort >+ * returning 0 on any invalid PFNs or non-free pages inside of the pageblock >+ * (even though it may still end up isolating some pages). > */ > static unsigned long isolate_freepages_block(struct compact_control *cc, > unsigned long blockpfn, >-- >1.7.7.6 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@xxxxxxxxx. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>