Re: [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 02, 2013 at 08:33:43PM +0800, Wanpeng Li wrote:
> If the page is poisoned by software inject w/ MF_COUNT_INCREASED flag, there
> is a false report 2nd try page recovery which is not truth, this patch fix it
> by report first try free buddy page recovery if MF_COUNT_INCREASED is set.
> 
> Before patch:
> 
> [  346.332041] Injecting memory failure at pfn 200010
> [  346.332189] MCE 0x200010: free buddy, 2nd try page recovery: Delayed
> 
> After patch:
> 
> [  297.742600] Injecting memory failure at pfn 200010
> [  297.742941] MCE 0x200010: free buddy page recovery: Delayed
> 
> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>

> ---
>  mm/memory-failure.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index b114570..6293164 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1114,8 +1114,10 @@ int memory_failure(unsigned long pfn, int trapno, int flags)
>  			 * shake_page could have turned it free.
>  			 */
>  			if (is_free_buddy_page(p)) {
> -				action_result(pfn, "free buddy, 2nd try",
> -						DELAYED);
> +				if (flags & MF_COUNT_INCREASED)
> +					action_result(pfn, "free buddy", DELAYED);
> +				else
> +					action_result(pfn, "free buddy, 2nd try", DELAYED);
>  				return 0;
>  			}
>  			action_result(pfn, "non LRU", IGNORED);
> -- 
> 1.7.5.4
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]