On Tue, Aug 20, 2013 at 11:56:15AM +0800, Chen Gang wrote: > For the implementation (patch 1/3), need fill buffer as full as > possible when buffer space is not enough. > > For the caller (patch 2/3, 3/3), need check the return value of > mpol_to_str(). > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> Won't simple check for mpol_to_str() < 0 be enough? IOW fix all callers to check that mpol_to_str exit without errors. As far as I see here are only two users. Something like show_numa_map ret = mpol_to_str(); if (ret) return ret; shmem_show_mpol ret = mpol_to_str(); if (ret) return ret; sure you'll have to change shmem_show_mpol statement to return int code. Won't this be more short and convenient? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>