Re: [PATCH v2 6/7] mm: munlock: remove redundant get_page/put_page pair on the fast path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2013 at 02:23:41PM +0200, Vlastimil Babka wrote:
> The performance of the fast path in munlock_vma_range() can be further improved
> by avoiding atomic ops of a redundant get_page()/put_page() pair.
> 
> When calling get_page() during page isolation, we already have the pin from
> follow_page_mask(). This pin will be then returned by __pagevec_lru_add(),
> after which we do not reference the pages anymore.
> 
> After this patch, an 8% speedup was measured for munlocking a 56GB large memory
> area with THP disabled.
> 
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> Reviewed-by: Jörn Engel <joern@xxxxxxxxx>

Acked-by: Mel Gorman <mgorman@xxxxxxx>

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]