Re: [PATCH v2] mm/hotplug: Verify hotplug memory range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Aug 2013 17:34:02 -0600 Toshi Kani <toshi.kani@xxxxxx> wrote:

> > Printing a u64 is problematic.  Here you assume that u64 is implemented
> > as unsigned long long.  But it can be implemented as unsigned long, by
> > architectures which use include/asm-generic/int-l64.h.  Such an
> > architecture will generate a compile warning here, but I can't
> > immediately find a Kconfig combination which will make that happen.
> 
> Oh, I see.  Should I add the casting below and resend it to you?
> 
>                 (unsigned long long)start, (unsigned long long)size);

I was going to leave it as-is and see if anyone else can find a way of
triggering the warning.  But other sites in mm/memory_hotplug.c have
the casts so I went ahead and fixed it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]