Re: [PATCH] thp: Fix deadlock situation in vma_adjust with huge page in page cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



That's great!

Best wishes,
-- 
Ning Qu


On Mon, Aug 12, 2013 at 6:55 AM, Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
Ning Qu wrote:
> In vma_adjust, the current code grabs i_mmap_mutex before calling
> vma_adjust_trans_huge. This used to be fine until huge page in page
> cache comes in. The problem is the underlying function
> split_file_huge_page will also grab the i_mmap_mutex before splitting
> the huge page in page cache. Obviously this is causing deadlock
> situation.
>
> This fix is to move the vma_adjust_trans_huge before grab the lock for
> file, the same as what the function is currently doing for anonymous
> memory.
>
> Tested, everything works fine so far.
>
> Signed-off-by: Ning Qu <quning@xxxxxxxxxx>

Thanks, applied.

--
 Kirill A. Shutemov


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]