On Thu, Aug 08, 2013 at 01:03:57PM +0800, Tang Chen wrote: > The comments of find_cpio_data() says: > > * @offset: When a matching file is found, this is the offset to the > * beginning of the cpio. ...... > > But according to the code, > > dptr = PTR_ALIGN(p + ch[C_NAMESIZE], 4); > nptr = PTR_ALIGN(dptr + ch[C_FILESIZE], 4); > .... > *offset = (long)nptr - (long)data; /* data is the cpio file */ > > @offset is the offset of the next file, not the matching file itself. > This is confused and may cause unnecessary waste of time to debug. > So fix it. > > v1 -> v2: > As tj suggested, rename @offset to @nextoff which is more clear to > users. And also adjust the new comments. > > Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx> > Reviewed-by: Zhang Yanfei <zhangyanfei@xxxxxxxxxxxxxx> Reviewed-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>