On Fri, 2013-08-09 at 10:32 -0500, Nathan Fontenot wrote:
> +void register_page_bootmem_memmap(unsigned long section_nr,
> + struct page *start_page, unsigned long size)
> +{
> + WARN_ONCE(1, KERN_INFO
> + "Sparse Vmemmap not fully supported for bootmem info nodes\n");
> +}
> #endif /* CONFIG_SPARSEMEM_VMEMMAP */
But SPARSEMEM_VMEMMAP is our default on ppc64 pseries ... and you are
select'ing the new option, so it looks like we are missing something
here...
Can you tell me a bit more, the above makes me nervous...
Cheers,
Ben.
> Index: powerpc/arch/powerpc/mm/mem.c
> ===================================================================
> --- powerpc.orig/arch/powerpc/mm/mem.c
> +++ powerpc/arch/powerpc/mm/mem.c
> @@ -297,12 +297,21 @@ void __init paging_init(void)
> }
> #endif /* ! CONFIG_NEED_MULTIPLE_NODES */
>
> +static void __init register_page_bootmem_info(void)
> +{
> + int i;
> +
> + for_each_online_node(i)
> + register_page_bootmem_info_node(NODE_DATA(i));
> +}
> +
> void __init mem_init(void)
> {
> #ifdef CONFIG_SWIOTLB
> swiotlb_init(0);
> #endif
>
> + register_page_bootmem_info();
> high_memory = (void *) __va(max_low_pfn * PAGE_SIZE);
> set_max_mapnr(max_pfn);
> free_all_bootmem();
> Index: powerpc/mm/Kconfig
> ===================================================================
> --- powerpc.orig/mm/Kconfig
> +++ powerpc/mm/Kconfig
> @@ -183,7 +183,7 @@ config MEMORY_HOTPLUG_SPARSE
> config MEMORY_HOTREMOVE
> bool "Allow for memory hot remove"
> select MEMORY_ISOLATION
> - select HAVE_BOOTMEM_INFO_NODE if X86_64
> + select HAVE_BOOTMEM_INFO_NODE if (X86_64 || PPC64)
> depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
> depends on MIGRATION
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@xxxxxxxxxxxxxxxx
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>