Hello, Johannes. On Tue, Aug 06, 2013 at 08:58:54AM -0400, Johannes Weiner wrote: > > if (anon_vma_clone(vma, pvma)) > > - return -ENOMEM; > > - > > - /* Then add our own anon_vma. */ > > - anon_vma = anon_vma_alloc(); > > - if (!anon_vma) > > - goto out_error; > > - avc = anon_vma_chain_alloc(GFP_KERNEL); > > - if (!avc) > > goto out_error_free_anon_vma; > > Which heavy work? anon_vma_clone() is anon_vma_chain_alloc() in a > loop. > > Optimizing error paths only makes sense if they are common and you > actually could save something by reordering. This matches neither. Yes, you are right. I drop this one. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>