On 2013/8/6 10:02, Li Zefan wrote: >> static struct cftype mem_cgroup_files[] = { >> { >> .name = "usage_in_bytes", >> @@ -5973,6 +6192,12 @@ static struct cftype mem_cgroup_files[] = { >> .read_u64 = mem_cgroup_hierarchy_read, >> }, >> { >> + .name = "cgroup.event_control", >> + .write_string = cgroup_write_event_control, >> + .flags = CFTYPE_NO_PREFIX, >> + .mode = S_IWUGO, >> + }, > > One of the misdesign of cgroup eventfd is, cgroup.event_control is > totally redunant... > ok. write_string() is needed to accept arguments and pass them to the event register function. still not good. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>