On 08/04/2013 12:55 PM, Andrea Arcangeli wrote:
On Fri, Aug 02, 2013 at 06:06:36PM +0200, Andrea Arcangeli wrote:
+ need_compaction = false;
This should be changed to "*need_compaction = false". It's actually a
cleanup because it's a nooperational change at runtime.
need_compaction was initialized to false by the only caller so it
couldn't harm. But it's better to fix it to avoid
confusion. Alternatively the above line can be dropped entirely but I
thought it was cleaner to have a defined value as result of the
function.
Found by Fengguang kbuild robot.
A new replacement patch 9/9 is appended below:
===
From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Subject: [PATCH] mm: zone_reclaim: compaction: add compaction to
zone_reclaim_mode
This adds compaction to zone_reclaim so THP enabled won't decrease the
NUMA locality with /proc/sys/vm/zone_reclaim_mode > 0.
It is important to boot with numa_zonelist_order=n (n means nodes) to
get more accurate NUMA locality if there are multiple zones per node.
Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Acked-by: Rik van Riel <riel@xxxxxxxxxx>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>