On Mon, Aug 05, 2013 at 10:58:13AM +0800, Li Zefan wrote: > > +struct cgroup *__cgroup_from_dentry(struct dentry *dentry, struct cftype **cftp) > > { > > - if (file_inode(file)->i_fop != &cgroup_file_operations) > > - return ERR_PTR(-EINVAL); > > - return __d_cft(file->f_dentry); > > + if (!dentry->d_inode || > > + dentry->d_inode->i_op != &cgroup_file_inode_operations) > > + return NULL; > > + > > + if (cftp) > > + *cftp = __d_cft(dentry); > > + return __d_cgrp(dentry->d_parent); > > } > > +EXPORT_SYMBOL_GPL(__cgroup_from_dentry); > > As we don't expect new users, why export this symbol? memcg can't be > built as a module. Yeah, I for some reason was thinking memcg could be bulit as module. Brainfart. Dropped. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>