On 08/02/2013 07:54 AM, Toshi Kani wrote:
......
/*
+ * acpi_root_table_init - Initialize acpi_gbl_root_table_list.
+ *
+ * This function will parse RSDT or XSDT, find all tables' phys addr,
+ * initialize acpi_gbl_root_table_list, and record all tables' phys addr
+ * in acpi_gbl_root_table_list.
+ */
+void __init acpi_root_table_init(void)
I think acpi_root_table_init() is a bit confusing with
acpi_boot_table_init(). Perhaps, something like
acpi_boot_table_pre_init() or early_acpi_boot_table_init() is better to
indicate that this new function is called before acpi_boot_table_init().
OK, will change it to early_acpi_boot_table_init().
+{
+ dmi_check_system(acpi_dmi_table);
+
+ /* If acpi_disabled, bail out */
+ if (acpi_disabled)
+ return;
+
+ /* Initialize the ACPI boot-time table parser */
+ if (acpi_table_init()) {
+ disable_acpi();
+ return;
+ }
+}
+
+/*
* acpi_boot_table_init() and acpi_boot_init()
* called from setup_arch(), always.
* 1. checksums all tables
@@ -1511,21 +1533,7 @@ static struct dmi_system_id __initdata acpi_dmi_table_late[] = {
void __init acpi_boot_table_init(void)
The comment of this function needs to be updated. For instance, it
describes acpi_table_init(), which you just relocated.
* acpi_table_init() is separate to allow reading SRAT without
* other side effects.
*
Sure. But I don't quite understand this comment. It seems that
acpi_table_init() has nothing to do with SRAT.
Do you know anything about this ?
{
- dmi_check_system(acpi_dmi_table);
-
- /*
- * If acpi_disabled, bail out
- */
- if (acpi_disabled)
- return;
I think this check is still necessary.
Yes. Will add it.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>