Re: [PATCH v2 1/2] uio: provide vm access to UIO_MEM_PHYS maps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[expanding Cc: to also include akpm and linux-mm]

Hello,

On Mon, Jul 29, 2013 at 01:09:14PM -0700, Greg Kroah-Hartman wrote:
> On Sun, Jul 28, 2013 at 12:09:37AM +0200, Uwe Kleine-König wrote:
> > This makes it possible to let gdb access mappings of the process that is
> > being debugged.
> > 
> > uio_mmap_logical was moved and uio_vm_ops renamed to group related code
> > and differentiate to new stuff.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > Changes since v1:
> >     - only use generic_access_phys ifdef CONFIG_HAVE_IOREMAP_PROT
> >     - fix all users of renamed struct
> 
> I still get a build error with this patch:
> 
>   MODPOST 384 modules
> ERROR: "generic_access_phys" [drivers/uio/uio.ko] undefined!
> 
> So something isn't quite right.
Ah, you built as a module and generic_access_phys isn't exported. The
other users of generic_access_phys (arch/x86/pci/i386.c and
drivers/char/mem.c) can only be builtin.

So the IMHO best option is to add an EXPORT_SYMBOL(generic_access_phys)
to mm/memory.c.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]