On Mon, Jul 29, 2013 at 03:08:15PM +0800, Li Zefan wrote: > +struct cgroup *cgroup_from_id(struct cgroup_subsys *ss, int id) > +{ > + rcu_lockdep_assert(rcu_read_lock_held(), > + "cgroup_from_id() needs rcu_read_lock()" > + " protection"); Maybe we want to add notation for &cgroup_mutex for completeness? > + return idr_find(&ss->root->cgroup_idr, id); > +} And maybe inline it? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>