On Wed 24-07-13 18:01:25, Li Zefan wrote: > This is a preparation to kill css_id. > > Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx> css_is_ancestor doesn't depend on the depth of the hierarchy while cgroup_is_descendant does. I do not think this would be an issue though as __mem_cgroup_same_or_subtree is not called from any hot path. Acked-by: Michal Hocko <mhocko@xxxxxxx> > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d12ca6f..626c426 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1434,7 +1434,7 @@ bool __mem_cgroup_same_or_subtree(const struct mem_cgroup *root_memcg, > return true; > if (!root_memcg->use_hierarchy || !memcg) > return false; > - return css_is_ancestor(&memcg->css, &root_memcg->css); > + return cgroup_is_descendant(memcg->css.cgroup, root_memcg->css.cgroup); > } > > static bool mem_cgroup_same_or_subtree(const struct mem_cgroup *root_memcg, > -- > 1.8.0.2 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>