On 07/24/2013 02:48 AM, Tejun Heo wrote:
On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote:
The Hot-Pluggable field in SRAT suggests if the memory could be
hotplugged while the system is running. Print it as well when
parsing SRAT will help users to know which memory is hotpluggable.
Signed-off-by: Tang Chen<tangchen@xxxxxxxxxxxxxx>
Reviewed-by: Wanpeng Li<liwanp@xxxxxxxxxxxxxxxxxx>
Acked-by: Tejun Heo<tj@xxxxxxxxxx>
But a nit below
+ pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx] %s\n",
+ node, pxm,
+ (unsigned long long) start, (unsigned long long) end - 1,
+ hotpluggable ? "Hot Pluggable" : "");
The following would be more conventional.
"...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : ""
Also, isn't "Hot Pluggable" a bit too verbose? "hotplug" should be
fine, I think.
Hi tj, Joe,
OK，will change it as you guys said.
Thank you very much.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href