On Tue, Jul 16, 2013 at 03:41:45PM +0200, Andrea Arcangeli wrote: >Zone reclaim locked breaks zone_reclaim_mode=1. If more than one >thread allocates memory at the same time, it forces a premature >allocation into remote NUMA nodes even when there's plenty of clean >cache to reclaim in the local nodes. > >Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> >Reviewed-by: Rik van Riel <riel@xxxxxxxxxx> >Acked-by: Rafael Aquini <aquini@xxxxxxxxxx> >Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Reviewed-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx> >--- > include/linux/mmzone.h | 6 ------ > mm/vmscan.c | 4 ---- > 2 files changed, 10 deletions(-) > >diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >index af4a3b7..9534a9a 100644 >--- a/include/linux/mmzone.h >+++ b/include/linux/mmzone.h >@@ -496,7 +496,6 @@ struct zone { > } ____cacheline_internodealigned_in_smp; > > typedef enum { >- ZONE_RECLAIM_LOCKED, /* prevents concurrent reclaim */ > ZONE_OOM_LOCKED, /* zone is in OOM killer zonelist */ > ZONE_CONGESTED, /* zone has many dirty pages backed by > * a congested BDI >@@ -540,11 +539,6 @@ static inline int zone_is_reclaim_writeback(const struct zone *zone) > return test_bit(ZONE_WRITEBACK, &zone->flags); > } > >-static inline int zone_is_reclaim_locked(const struct zone *zone) >-{ >- return test_bit(ZONE_RECLAIM_LOCKED, &zone->flags); >-} >- > static inline int zone_is_oom_locked(const struct zone *zone) > { > return test_bit(ZONE_OOM_LOCKED, &zone->flags); >diff --git a/mm/vmscan.c b/mm/vmscan.c >index 2cff0d4..042fdcd 100644 >--- a/mm/vmscan.c >+++ b/mm/vmscan.c >@@ -3595,11 +3595,7 @@ int zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order) > if (node_state(node_id, N_CPU) && node_id != numa_node_id()) > return ZONE_RECLAIM_NOSCAN; > >- if (zone_test_and_set_flag(zone, ZONE_RECLAIM_LOCKED)) >- return ZONE_RECLAIM_NOSCAN; >- > ret = __zone_reclaim(zone, gfp_mask, order); >- zone_clear_flag(zone, ZONE_RECLAIM_LOCKED); > > if (!ret) > count_vm_event(PGSCAN_ZONE_RECLAIM_FAILED); > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@xxxxxxxxx. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>