Matthew Wilcox wrote: > On Mon, Jul 15, 2013 at 01:47:47PM +0300, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> > > > > There's only one caller of do_generic_file_read() and the only actor is > > file_read_actor(). No reason to have a callback parameter. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> > > Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> > > Would it make sense to do the same thing to do_shmem_file_read()? > > From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> > > There's only one caller of do_shmem_file_read() and the only actor is > file_read_actor(). No reason to have a callback parameter. > > Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> Looks good to me: Reviewed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> v3.11-rc1 brings one more user for read_actor_t -- lustre. But it seemes it's artifact of ages when f_op had ->sendfile and it's not in use anymore. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>