Re: [PATCH 16/18] sched: Avoid overloading CPUs on a preferred NUMA node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2013 at 11:55:24PM +0800, Hillf Danton wrote:
> On Mon, Jul 15, 2013 at 11:20 PM, Mel Gorman <mgorman@xxxxxxx> wrote:
> > +
> > +static int task_numa_find_cpu(struct task_struct *p, int nid)
> > +{
> > +       int node_cpu = cpumask_first(cpumask_of_node(nid));
> [...]
> >
> > +       /* No harm being optimistic */
> > +       if (idle_cpu(node_cpu))
> > +               return node_cpu;
> >
> [...]
> > +       for_each_cpu(cpu, cpumask_of_node(nid)) {
> > +               dst_load = target_load(cpu, idx);
> > +
> > +               /* If the CPU is idle, use it */
> > +               if (!dst_load)
> > +                       return dst_cpu;
> > +
> Here you want cpu, instead of dst_cpu, I guess.

Crap, yes. Thanks!

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]