Re: [PATCH 1/1] mm: mempolicy: fix mbind_range() && vma_adjust() interaction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 8 Jul 2013 20:05:01 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> vma_adjust() does vma_set_policy(vma, vma_policy(next)) and this
> is doubly wrong:
> 
> 1. This leaks vma->vm_policy if it is not NULL and not equal to
>    next->vm_policy.
> 
>    This can happen if vma_merge() expands "area", not prev (case 8).
> 
> 2. This sets the wrong policy if vma_merge() joins prev and area,
>    area is the vma the caller needs to update and it still has the
>    old policy.
> 
> Revert 1444f92c "mm: merging memory blocks resets mempolicy" which
> introduced these problems.
> 
> Change mbind_range() to recheck mpol_equal() after vma_merge() to
> fix the problem 1444f92c tried to address.
> 

So I assume the kernel still passes Steven's testcase from the
1444f92c changelog?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]