On Sun, Jul 07, 2013 at 07:41:54PM +0300, Pekka Enberg wrote: >On Mon, Jul 1, 2013 at 6:48 PM, Christoph Lameter <cl@xxxxxxxxx> wrote: >> On Mon, 24 Jun 2013, David Rientjes wrote: >> >>> On Mon, 24 Jun 2013, Wanpeng Li wrote: >>> >>> > This patch shares s_next and s_stop between slab and slub. >>> > >>> >>> Just about the entire kernel includes slab.h, so I think you'll need to >>> give these slab-specific names instead of exporting "s_next" and "s_stop" >>> to everybody. >> >> He put the export into mm/slab.h. The headerfile is only included by >> mm/sl?b.c . > >But he then went on to add globally visible symbols "s_next" and >"s_stop" which is bad... > >Please send me an incremental patch on top of slab/next to fix this >up. Otherwise I'll revert it before sending a pull request to Linus. > > Pekka Hi Pekka, I attach the incremental patch in attachment. ;-) Regards, Wanpeng Li