On Thu 04-07-13 09:10:39, Joe Perches wrote: > On Thu, 2013-07-04 at 18:07 +0200, Michal Hocko wrote: > > A warning is printed when the new value is ignored. > > [] > > > + printk(KERN_WARNING "min_free_kbytes is not updated to %d" > > + "because user defined value %d is preferred\n", > > + new_min_free_kbytes, user_min_free_kbytes); > > Please use pr_warn and coalesce the format. Sure can do that. mm/page_alloc.c doesn't seem to be unified in that regards (44 printks and only 4 pr_<foo>) so I used printk. > You'd've noticed a missing space between %d and because. True Thanks -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>