On Thu 27-06-13 11:05:50, Anton Vorontsov wrote: > On Thu, Jun 27, 2013 at 06:11:03PM +0200, Michal Hocko wrote: > > > If we send critical but there isn't big memory pressure, maybe > > > critical handler would kill some process and the result is that > > > killing another process unnecessary. That's really thing we should > > > avoid. > > Yes, so that is why I actually want to ack the patch... It might be not an > ideal solution, but to me it seems like a good for the time being. I am still not sure why a) nr_taken shouldn't be used instead of nr_scanned b) why there should be any signal if the current allocator dies and the direct reclaim is terminated prematurely. [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>