On Wed, Jun 26, 2013 at 11:01:16AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 26, 2013 at 04:49:02PM +0200, Michal Hocko wrote: > > 835f2f51 (staging: zcache: enable zcache to be built/loaded as a module) > > introduced in 3.10-rc1 has introduced a bug for zcache=FOO module > > parameter processing. > > > > zcache_comp_init return code doesn't agree with crypto_has_comp which > > uses 1 for the success unlike zcache_comp_init which uses 0. This > > causes module loading failure even if the given algorithm is supported: > > [ 0.815330] zcache: compressor initialization failed > > > > Reported-by: Cristian Rodríguez <crrodriguez@xxxxxxxxxxxx> > > Signed-off-by: Michal Hocko <mhocko@xxxxxxx> > > Looks OK to me. > > Cc-ing Greg. That's nice, but can someone resend it in a format that I can apply it in, with your ack? thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>