On Tue, Jun 25, 2013 at 12:02:13PM +0800, Jeff Liu wrote: > From: Jie Liu <jeff.liu@xxxxxxxxxx> > > For those file systems(btrfs/ext4/ocfs2/tmpfs) that support > SEEK_DATA/SEEK_HOLE functions, we end up handling the similar > matter in lseek_execute() to update the current file offset > to the desired offset if it is valid, ceph also does the > simliar things at ceph_llseek(). > > To reduce the duplications, this patch make lseek_execute() > public accessible so that we can call it directly from the > underlying file systems. Umm... I like it, but it needs changes: * inode argument of lseek_execute() is pointless (and killed off in vfs.git, actually) * I'm really not happy about the name of that function. For a static it's kinda-sort tolerable, but for something global, let alone exported... I've put a modified variant into #for-next; could you check if you are still OK with it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>